Skip to content

Commit

Permalink
Show CTA at bottom of anonymous editor warning
Browse files Browse the repository at this point in the history
Bug: T164628
Change-Id: I7e10409e2854d803f8de4167f18fe4a67ed3ddee
  • Loading branch information
jdlrobson authored and jrobson committed Aug 29, 2017
1 parent 1de3c51 commit df46170
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 2 deletions.
5 changes: 3 additions & 2 deletions extension.json
Expand Up @@ -478,7 +478,8 @@
"22": "mobile-frontend-editor-switch-confirm",
"23": "mobile-frontend-editor-switch-editor",
"24": "mobile-frontend-editor-switch-visual-editor",
"25": "mobile-frontend-editor-anonwarning"
"25": "mobile-frontend-editor-anonwarning",
"26": "mobile-frontend-editor-anon-cta-message"
}
},
"mobile.editor.overlay": {
Expand Down Expand Up @@ -1392,4 +1393,4 @@
"includes/ServiceWiring.php"
],
"manifest_version": 1
}
}
1 change: 1 addition & 0 deletions i18n/en.json
Expand Up @@ -37,6 +37,7 @@
"Yuvaraj Pandian"
]
},
"mobile-frontend-editor-anon-cta-message": "Log in or create an account to track your edits",
"abusefilter-edit-builder-vars-user-mobile": "Whether or not a user is editing through the mobile interface",
"mobile-frontend-account-create-captcha-placeholder": "Enter confirmation code",
"mobile-frontend-categories-heading": "<strong>Categories</strong>",
Expand Down
1 change: 1 addition & 0 deletions i18n/qqq.json
Expand Up @@ -38,6 +38,7 @@
"Arthur2e5"
]
},
"mobile-frontend-editor-anon-cta-message": "Call to action, shown to anonymous editors before they edit",
"abusefilter-edit-builder-vars-user-mobile": "AbuseFilter extension rule variable that allows distinguishing edits based on if they have been made using the editor of MobileFrontend or not.",
"mobile-frontend-account-create-captcha-placeholder": "Placeholder for captcha input field",
"mobile-frontend-categories-heading": "Title of the list of categories this page is categorized in.\n{{Identical|Category}}",
Expand Down
Expand Up @@ -5,4 +5,5 @@
{{#loginButton}}{{>button}}{{/loginButton}}
{{#signupButton}}{{>button}}{{/signupButton}}
</div>
<p>{{ctaMessage}}</p>
</div>
5 changes: 5 additions & 0 deletions resources/mobile.editor.common/editor.less
Expand Up @@ -14,6 +14,11 @@
.mw-ui-button {
margin-bottom: 15px;
}
> p {
text-align: center;
font-style: italic;
font-size: 0.875em;
}
}

.preview {
Expand Down
1 change: 1 addition & 0 deletions resources/mobile.editor.overlay/EditorOverlay.js
Expand Up @@ -67,6 +67,7 @@
* @cfg {mw.Api} defaults.api an api module to retrieve pages
*/
defaults: $.extend( {}, EditorOverlayBase.prototype.defaults, {
ctaMessage: mw.msg( 'mobile-frontend-editor-anon-cta-message' ),
loginButton: new Button( {
block: true,
label: mw.msg( 'mobile-frontend-watchlist-cta-button-login' )
Expand Down

0 comments on commit df46170

Please sign in to comment.