SECURITY: Escape start argument before passing to pygments

Issue identified by Yorick Koster Bug: T158689 Change-Id: Ib55f7a38edbdd39c9587794d250e22d3b26950be
wikimedia · Apr 6, 2017 · 2d5a60a · 2d5a60a
1 parent 56a61d5
commit 2d5a60a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/SyntaxHighlight_GeSHi.class.php b/SyntaxHighlight_GeSHi.class.php
@@ -263,8 +263,8 @@ public static function highlight( $code, $lang = null, $args = array() ) {
 		}
 
 		// Starting line number
-		if ( isset( $args['start'] ) ) {
-			$options['linenostart'] = $args['start'];
+		if ( isset( $args['start'] ) && ctype_digit( $args['start'] ) ) {
+			$options['linenostart'] = (int)$args['start'];
 		}
 
 		if ( $inline ) {