Skip to content

Commit

Permalink
Don't force #p-lang to show using jQuery.fn.show
Browse files Browse the repository at this point in the history
It's a performance anti-pattern; see
<jquery/jquery.com#88 (comment)>

Change-Id: If6e521c27975f7d64932268fde5778aa63fd08ee
  • Loading branch information
atdt committed Mar 8, 2015
1 parent a672e1f commit 57b617f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions resources/js/ext.uls.interface.js
Expand Up @@ -315,8 +315,8 @@
$pLang = $( '#p-lang' );
// Add an element near the interlanguage links header
$ulsTrigger = $( '<span>' ).addClass( 'uls-settings-trigger' );
// Append ULS cog to languages section, but make sure it is visible.
$pLang.show().prepend( $ulsTrigger );
// Append ULS cog to languages section.
$pLang.prepend( $ulsTrigger );
// Take care of any other elements with this class.
$ulsTrigger = $( '.uls-settings-trigger' );
// Remove the dummy link, which was added to make sure that the section appears
Expand Down

0 comments on commit 57b617f

Please sign in to comment.