Merge "Bump cache key for check results" into wmf/1.31.0-wmf.23

wikimedia · Feb 28, 2018 · 2a9c8a2 · 2a9c8a2
2 parents b4b0c1e + ade0a5d
commit 2a9c8a2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Api/ResultsCache.php b/src/Api/ResultsCache.php
@@ -42,7 +42,7 @@ public function makeKey( EntityId $entityId, $languageCode = null ) {
 		return $this->cache->makeKey(
 			'WikibaseQualityConstraints', // extension
 			'checkConstraints', // action
-			'v2', // API response format version
+			'v2.1', // API response format version; .1: T188384
 			$entityId->getSerialization(),
 			$languageCode
 		);

diff --git a/tests/phpunit/Api/ResultsCacheTest.php b/tests/phpunit/Api/ResultsCacheTest.php
@@ -37,11 +37,11 @@ public function testMakeKey() {
 		$resultsCache = new ResultsCache( WANObjectCache::newEmpty() );
 
 		$this->assertSame(
-			'local:WikibaseQualityConstraints:checkConstraints:v2:Q5:en',
+			'local:WikibaseQualityConstraints:checkConstraints:v2.1:Q5:en',
 			$resultsCache->makeKey( new ItemId( 'Q5' ), 'en' )
 		);
 		$this->assertSame(
-			'local:WikibaseQualityConstraints:checkConstraints:v2:P31:de',
+			'local:WikibaseQualityConstraints:checkConstraints:v2.1:P31:de',
 			$resultsCache->makeKey( new PropertyId( 'P31' ), 'de' )
 		);
 	}
@@ -60,7 +60,7 @@ public function testMakeKey_qqx() {
 
 		$key = $resultsCache->makeKey( new ItemId( 'Q5' ), 'qqx' );
 
-		$this->assertSame( 'local:WikibaseQualityConstraints:checkConstraints:v2:Q5:qqx', $key );
+		$this->assertSame( 'local:WikibaseQualityConstraints:checkConstraints:v2.1:Q5:qqx', $key );
 	}
 
 	public function testGet() {