Link to constraint statement instead of statement group

Now that each individual statement has an HTML ID, we can link to the correct constraint statement, not just to the statement group for all constraint statements. Bug: T169224 Change-Id: Id801971f05e41bd29f8d3f104e63eb006fbefdae
wikimedia · Jul 16, 2018 · 978863a · 978863a
1 parent 42a0250
commit 978863a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Api/CheckResultsRenderer.php b/src/Api/CheckResultsRenderer.php
@@ -82,8 +82,7 @@ public function checkResultToArray( CheckResult $checkResult ) {
 
 		$title = $this->entityTitleLookup->getTitleForId( $constraintPropertyId );
 		$typeLabel = $this->entityIdLabelFormatter->formatEntityId( new ItemId( $typeItemId ) );
-		// TODO link to the statement when possible (T169224)
-		$link = $title->getFullURL() . '#' . $this->config->get( 'WBQualityConstraintsPropertyConstraintId' );
+		$link = $title->getFullURL() . '#' . $constraintId;
 
 		$constraint = [
 			'id' => $constraintId,

diff --git a/tests/phpunit/Api/CheckResultsRendererTest.php b/tests/phpunit/Api/CheckResultsRendererTest.php
@@ -175,7 +175,7 @@ public function testCheckResultToArray_Constraint() {
 		$this->assertSame( $checkResult->getConstraintId(), $constraint['id'] );
 		$this->assertSame( 'Q1', $constraint['type'] );
 		$this->assertSame( 'Q1', $constraint['typeLabel'] );
-		$this->assertSame( 'http://wiki.test/P1#P2302', $constraint['link'] );
+		$this->assertSame( 'http://wiki.test/P1#P1$31d77e02-e1bd-423e-811e-7f6dd5da0b90', $constraint['link'] );
 		$this->assertSame( 'http://wiki.test/Talk:P1', $constraint['discussLink'] );
 	}