Add 'text' param to upload_image

[abartov]

with a nil default so as not to break existing code

[zeljkofilipin]

Thanks for the contribution! This repository is just a mirror of the original one in Gerrit:

https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api

Could you please send the patch there? (I will do it on Monday, if you do not do it by then.)

[zeljkofilipin]

Moved to gerrit: https://gerrit.wikimedia.org/r/#/c/334992/

[zeljkofilipin]

This is now merged into master. Should we release the new version of the gem? Or can this wait? We do not have any strict policy on when to release the gem.

[abartov]

I'd like to see this released as a new gem, yes. It actually plugs a not-insignificant weakness in upload_image: before it, the only way to make the upload include licensing information, and author and description templates, as e.g. Commons would expect, was to pass *all* of it in the comment field. Which is ugly and limited. I would like to use this feature in a tool I maintain that relies on the Ruby API[1], to resolve an open issue, so I'd welcome a release as a gem soon. Thanks, A. [1] https://github.com/abartov/pronuncify

…

On Mon, Jan 30, 2017 at 7:50 AM Željko Filipin ***@***.***> wrote: This is now merged into master. Should we release the new version of the gem? Or can this wait? We do not have any strict policy on when to release the gem. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAECp4R3TlJ4EgxDvWL0kEXIqFRfYmakks5rXgbDgaJpZM4LwbQj> .

[zeljkofilipin]

Released: https://rubygems.org/gems/mediawiki_api