Skip to content

Commit

Permalink
Revert part of 55da309: Setting up template args exposes other bugs
Browse files Browse the repository at this point in the history
At these the 3 bugs below are from that. Potentially two other
bug repots filed in Phab could also be from this same source.

Bug: T301948
Bug: T302007
Bug: T301986
Change-Id: Ic14a7b77442d8404e5d0c7da6517a3cb81b08359
  • Loading branch information
subbuss committed Feb 18, 2022
1 parent ea7ed64 commit 61f39cd
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/Wt2Html/TT/TemplateHandler.php
Expand Up @@ -1068,7 +1068,12 @@ private function onTemplate( Token $token ): TokenHandlerResult {
/* If $tgt is not null, target will be present. */
$templateName = $tgt['target'];
$templateTitle = $tgt['title'];
$attribs = array_slice( $token->attribs, 1 ); // Strip template name

// FIXME: This is a source of a lot of issues since templateargs
// get looked up from the Frame and yield these tokens which then enter
// the token stream. See T301948 and others from wmf.22
// $attribs = array_slice( $token->attribs, 1 ); // Strip template name
$attribs = [];

// We still need to check for limit violations because of the
// higher precedence of extension tags, which can result in nested
Expand Down

0 comments on commit 61f39cd

Please sign in to comment.