Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra curlies from xrightarrow #38

Merged
merged 1 commit into from Apr 4, 2020

Conversation

physikerwelt
Copy link
Member

Bug: T185027

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.342% when pulling 0d54b68 on physikerwelt:T185027 into 7e5df40 on wikimedia:master.

@physikerwelt
Copy link
Member Author

@Pchelolo can you do a code review here?

@@ -1,2 +0,0 @@
instrumentation:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, but ok.

@Pchelolo
Copy link

I was only able to make a superficial review, since I do not entirely understand what this does.

It's a separate thing, but if you could add a comment for every function grouping with some short explanation and demystification of its name - that would be really cool. I won't require it for this patch however.

Remember, I don't have push rights here, so please self-merge.

@physikerwelt physikerwelt merged commit 68f1ae3 into wikimedia:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants