Fix normalizing multiple whitespace chars

wikimedia · Jun 21, 2017 · 7323ad0 · 7323ad0
1 parent 4705414
commit 7323ad0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -328,7 +328,7 @@ Title.newFromText = function(title, siteInfo, defaultNs) {
         throw new TypeError('Invalid type of siteInfo parameter. Must be a string');
     }
 
-    title = title.replace(/ /g, '_')
+    title = title
     // Strip Unicode bidi override characters.
     .replace(/\xE2\x80[\x8E\x8F\xAA-\xAE]/g, '')
     // Clean up whitespace

diff --git a/test/index.js b/test/index.js
@@ -151,6 +151,7 @@ function doTest(formatversion) {
             [ 'en.wikipedia.org', ':Test', 'Test'],
             [ 'en.wikipedia.org', ': Test', 'Test'],
             [ 'en.wikipedia.org', ':_Test_', 'Test'],
+            [ 'en.wikipedia.org', 'Test 123  456   789', 'Test_123_456_789' ],
             [ 'en.wikipedia.org', '💩', '💩'],
             [ 'en.wikipedia.org', 'Foo:bar', 'Foo:bar'],
             [ 'en.wikipedia.org', 'Talk: foo', 'Talk:Foo'],