Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility layer for PHP uppercase chars #52

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

johngian
Copy link
Contributor

@johngian johngian commented Mar 3, 2022

  • Update mapping using maintenance script: generatePhpCharToUpperMappings.php
  • Adapt handling for chars that are remaining the same

@johngian johngian force-pushed the php-js-upper-compat branch 3 times, most recently from 9853efe to 3bea74d Compare March 3, 2022 17:00
* Update mapping using maintenance script: generatePhpCharToUpperMappings.php
* Adapt handling for chars that are remaining the same

Bug: T301600
@johngian johngian changed the title Update compat layer for upper chars between php/js Update compatibility layer for PHP uppercase chars Mar 3, 2022
@arlolra arlolra merged commit 07e2cc5 into wikimedia:master Mar 3, 2022
@arlolra
Copy link
Member

arlolra commented Mar 3, 2022

I added a small change to this in 35a5eb7

The one you generated is slightly different than what is currently in MediaWiki, so I preferred that,
https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.Title/phpCharToUpper.json

@arlolra
Copy link
Member

arlolra commented Mar 3, 2022

This was tagged and published as v0.7.5

@johngian johngian deleted the php-js-upper-compat branch March 4, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants