Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SectionProfiler: Do not attempt to use null values as arrays
When SectionProfiler::getFunctionStats() is called, the 'start' and 'end' member variables may be null if no code called the scopedProfileIn()/scopedProfileOut() methods on this profiler instance. This can occur, for instance, when generating the parser limit report for wikitext that did not include expensive parser functions. In PHP 7.4, attemping to use a null value as an array generates a PHP Notice.[1] This patch adds a check to SectionProfiler::getFunctionStats to verify that the 'start' value is an array before attempting to access its keys. --- [1] https://github.com/php/php-src/blob/php-7.4.0RC1/UPGRADING#L25 Bug: T233012 Change-Id: I2d35bfddfcc4c194aa71265e40387f2f2914e3a5
- Loading branch information