Prepare 6.3.0 Release #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to drop Node 10: #18 |
edg2s
requested changes
Dec 17, 2021
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@wikimedia/mw-node-qunit", | |||
| "version": "6.2.1", | |||
| "version": "6.3.0", | |||
There was a problem hiding this comment.
You need to update package-lock.json too (run npm i)
manicki
force-pushed
the
manicki-patch-1
branch
from
e384911
to
9a43eb3
Compare
edg2s
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have, potentially wrongly, identified version 6.2.1 to be a reason why linting jobs of MobileFrontend extension (LTS REL1_35 branch at least) on WMF's Jenkins CI fail. That version results in MobileFrontend installing eslint version 6.8, whereas plugins used by eslint-config-wikimedia 0.21 actually seem to require eslint 7.