Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] v7.0.0 #30

Merged
merged 3 commits into from
Mar 30, 2023
Merged

[Release] v7.0.0 #30

merged 3 commits into from
Mar 30, 2023

Conversation

jdlrobson
Copy link
Member

No description provided.

@jdlrobson
Copy link
Member Author

once package.json is updated I will do the release.
Apparently this is blocking https://phabricator.wikimedia.org/T333407

jdforrester
jdforrester requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@jdforrester jdforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use npm version major --git-tag-version=false, which will also update package-lock.json.

@jdlrobson jdlrobson merged commit a30e6a1 into master Mar 30, 2023
@jdlrobson
Copy link
Member Author

Thanks @jdforrester you prompted me to create https://www.mediawiki.org/wiki/Readers/Web/Team/Releasing_libraries to write this down for the team. Feel free to jump in with any edits there if you feel like I'm missing something or have any handy links to better documentation.

@jdlrobson jdlrobson deleted the v7.0.0 branch June 14, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdforrester jdforrester jdforrester approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdlrobson @jdforrester