Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.1.0 #8

Merged
merged 2 commits into from
Oct 22, 2019
Merged

6.1.0 #8

merged 2 commits into from
Oct 22, 2019

Conversation

jdlrobson
Copy link
Member

Release 6.1.0

  • Fix the tests
  • Add a generic setUp function to DRY up code in Popups repo.

@jdlrobson
Update mw-node-qunit tests
267a913 
Refresh the tests to express how v6 works.
A new function setUp is added to handle the case where tests do
not want to explicitly express dependencies. It is invoked by
the --globals keyword and will be used by Popups

Support for the `this.sandbox` mechanism is removed - use of
sinon.sandbox.create() is preferred going forward.
@jdlrobson
Release 6.1.0
209514f
@jdlrobson jdlrobson merged commit f040979 into wikimedia:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostajh kostajh kostajh approved these changes

@egardner egardner Awaiting requested review from egardner

@jandre3000 jandre3000 Awaiting requested review from jandre3000

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdlrobson @kostajh