Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule name gets flipped #5

Closed
MohammadYounes opened this issue Jan 1, 2014 · 2 comments
Closed

Rule name gets flipped #5

MohammadYounes opened this issue Jan 1, 2014 · 2 comments

Comments

@MohammadYounes
Copy link
Contributor

LTR CSS
.content > .right:not(.ignore) {
  display:block;
}
Expected:
.content > .right:not(.ignore) {
  display:block;
}
Result:
.content > .left:not(.ignore) {
  display:block;
}
MohammadYounes added a commit to MohammadYounes/cssjanus that referenced this issue Jan 1, 2014
trevorparscal added a commit that referenced this issue Jan 28, 2014
Fix rule name gets flipped issue #5
@dralshehri
Copy link

This commit resulted in an error with flipping URLs when flags are on.

It should be reverted back as it appears that there was no problem at first.

After reverting this commit, I tested this:

.content > .right:not(.ignore) {display:block;}

and It was as expected i.e not changed.

@MohammadYounes
Copy link
Contributor Author

@m-alshehri Yes you are right, this will affect URLs containing .right or .left such as : url(/content/arrow.left.png)

When I made the fix, I was using version 1.0.1, which was flipping the rule name .. What actually fixed it! is the updated lookAheadNotOpenBracePattern

v1.0.1: '(?!(' + nmcharPattern + '|\\r?\\n|\\s|#|\\:|\\.|\\,|\\+|>)*?{)'

v1.0.2: '(?!(' + nmcharPattern + '|\\r?\\n|\\s|#|\\:|\\.|\\,|\\+|>|\\(|\\))*?{)'

I'll issue a PR to revert this change, thanks.

MohammadYounes added a commit to MohammadYounes/cssjanus that referenced this issue Feb 25, 2014
Krinkle added a commit that referenced this issue Jul 4, 2014
This reverts commit 47819f3.

Closes #10
Fixes #19
Krinkle added a commit that referenced this issue Jul 4, 2014
This reverts commit 47819f3.

Closes #10
Fixes #19
@Krinkle Krinkle added the bug label Jul 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants