border-radius with !important produces wrong output

[ocean90]

This PR adds a test for div { border-radius: 0 !important } where the expected output would be the same. But you get div { border-radius: !important 0 }.

Another added test is div { border-radius: 8px 7px !important } which should output div { border-radius: 7px 8px !important }, but you get div { border-radius: 7px 8px } !important.

Related: https://core.trac.wordpress.org/ticket/29038

[ocean90]

The RegExp is based on https://code.google.com/p/cssjanus/source/browse/trunk/cssjanus.py.

[ntwb]

@Krinkle Is there anything holding back this pull request from being merged?

I also just tested both of the reported issues here at https://cssjanus.github.io/

The first issue div { border-radius: 0 !important } still produces div { border-radius: !important 0 }

The second issue is now fixed as part of v1.1.1 / 2014-11-19

[trevorparscal]

It being able to be merged cleanly might help.

[ocean90]

@trevorparscal I've updated this pull request to support the recent changes.

[Krinkle]

@ocean90 Thanks! I'll try to get it merged this week.

[ntwb]

@Krinkle Any chance of maybe merging this this week? 😉

[Krinkle]

@ocean90 I made a few minor changes (adjust indentation of borderRadiusRegExp, document border-radius syntax, capitalise @param {Array}, and added tests for four-values with slashes). I also simplified the implementation in follow-up commit 1faff3f. It's slightly less performant due to Array#slice and Array#filter overhead, but makes it a lot simpler.

@ntwb Done!

[ntwb]

Thanks :)

[ocean90]

Thanks @Krinkle!