Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixbox #110

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Fixbox #110

merged 5 commits into from
Sep 8, 2022

Conversation

jdlrobson
Copy link
Member

No description provided.

After talking to Nick we'll do this in the command itself

e.g.
./pixel.js reference -b latest-release -c 829039
This updates the box to reflect the fact that comparison
branch may have additional changes
@nicholasray
Copy link
Contributor

nicholasray commented Sep 8, 2022

The only issue I'm seeing is when I run master against master with a change e.g.:

pixel.js reference
pixel.js test -c 830700

I see "master against master". Can you replicate?

Screen Shot 2022-09-08 at 4 23 28 PM

@jdlrobson
Copy link
Member Author

yep just saw the same.. looking!

@jdlrobson
Copy link
Member Author

Fixed!

@nicholasray nicholasray merged commit 112e96b into main Sep 8, 2022
@nicholasray nicholasray deleted the fixbox branch September 8, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants