Fix openReportIfNecessary method when report path name is different t… #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasray
force-pushed
the
fix-desktop-dev-file-path
branch
from
4222412
to
fe13c54
Compare
jdlrobson
approved these changes
Nov 17, 2022
…han the group name The desktop-dev group was failing to write to/open the report in the openReportIfNecessary method because it was looking for a `dektop-dev` folder instead of a `desktop-development` folder. Since the report path is configurable and may differ from the group name, we need to look at the config in order to determine the report path. Additionally: * Refactor the removeTestFolder method to have a relativePath param instead of passing the entire config.
nicholasray
force-pushed
the
fix-desktop-dev-file-path
branch
from
fe13c54
to
6cc520f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…han the group name
The desktop-dev group was failing to write to/open the report because it was looking for a
dektop-devfolder instead of adesktop-developmentfolder. Since the report path is configurable and may differ from the group name, we need to look at the config in order to determine the report path.Additionally: