Update Test page content and add test case for TOC scrollable indicator #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasray
reviewed
Jan 13, 2023
| @@ -2,7 +2,7 @@ FROM mariadb:10.6.7 | |||
|
|
|||
| COPY src/seedDb.sh /docker-entrypoint-initdb.d/ | |||
|
|
|||
| ARG database="database_2022-10-07_10-53-14-0600(MDT).tar.gz" | |||
| ARG database="database_2023-01-11_12-42-02-0600(CST).tar.gz" | |||
nicholasray
reviewed
Jan 13, 2023
| } | ||
| tocElement.scrollBy( 0, tocElement.scrollHeight ); | ||
| // Scroll up 30px from the bottom of the TOC to allow the scrollable indicator to show | ||
| tocElement.scrollBy( 0, -30 ); |
There was a problem hiding this comment.
We might need to wait a number of frames after the scroll as I noticed that one test failed for me because it seems that the new scroll position hadn't been painted yet [1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary