Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mw undefined error handling in moduleReady #187

Merged
merged 1 commit into from Apr 19, 2023
Merged

Add mw undefined error handling in moduleReady #187

merged 1 commit into from Apr 19, 2023

Conversation

nicholasray
Copy link
Contributor

moduleReady assumed the global mw was present which is not the case when the server returns an error. Instead of silently failing, reject the promise.

Bug: T335003

@nicholasray
Add mw undefined error handling in moduleReady
3aa604b 
moduleReady assumed the global `mw` was present which is not the case when the
server returns an error. Instead of silently failing, reject the promise.

Bug: T335003
@nicholasray
Copy link
Contributor Author

Using this debug and diagnose T335003

@nicholasray nicholasray merged commit 14c22c8 into main Apr 19, 2023
1 check failed
@nicholasray nicholasray deleted the debugModuleReady branch April 19, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@nicholasray