Pass -T parameter to docker-compose #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to run when the input device is not a TTY
|
Forgot to push this to master. |
nicholasray
reviewed
May 9, 2022
| @@ -78,7 +78,7 @@ async function processCommand( type, opts ) { | |||
| // Execute main.js. | |||
| await batchSpawn.spawn( | |||
| 'docker-compose', | |||
| [ 'exec', 'mediawiki', '/src/main.js', JSON.stringify( opts ) ] | |||
| [ 'exec', '-T', 'mediawiki', '/src/main.js', JSON.stringify( opts ) ] | |||
There was a problem hiding this comment.
I think this may be causing the script to ignore presses to ctrl-c on one of my laptops (to abort the script), however it seems to respond fine on my other computer so I'm not sure. I think it also disables color output at least for that script. Can you replicate?
Also, what was the original problem? Running the cron job on cloud vps?
There was a problem hiding this comment.
Try running in a cronjob context locally and you should be able to replicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to run when the input device is not a TTY