Add Echo test group #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses 3 accounts for 3 types of users - Requires update to Docker image, please reset database to use. Accounts have been set up with 0, 1 and 100+ notifications. - Smoke tests covering both Vector and Minerva skins. - Due to legacy Vector coverage, special affordances are made to handle the dancing tabs problem and Echo bugs.
This comment was marked as resolved.
This comment was marked as resolved.
A new database snapshot was added as part of this commit. seedDb.sh, a script that adds the seed data to the databas and that runs for new users or when `npm run clean` is used, is made to reflect this change.
|
For some reason, the |
nicholasray
reviewed
Jun 1, 2022
Yep I can replicate. Debugging as we speak.. [RESOLVED] Fixed in a0a384f |
When tagged Vector the code can freeze.
This seems to avoid the issue with needing the delay Hat tip to @nray for debugging this one,
|
Okay this should be ready for another review @nray ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accounts have been set up with 0, 1 and 100+ notifications.
the dancing tabs problem and Echo bugs.
This will help with testing of https://phabricator.wikimedia.org/T301263 and later https://phabricator.wikimedia.org/T257143