Placeholder content for group index.html file while run is in progress #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user tried to view a group's report while that group was running, its images could be missing since Backstop clears out a group's images when it begins a run This commit updates the group's index file when the run begins indicating the group's run is in progress This placeholder info persists until the run completes The actual report appears when the run is done
|
Note that this is granular to Desktop, Mobile, Codex etc, so you only see the placeholder if Backstop is currently regenerating screenshots for that respective group |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user tried to view a group's report while that group was running, its images could be missing since Backstop clears out a group's images when it begins a run
This commit updates the group's index file when the run begins indicating the group's run is in progress
For example, if Desktop screenshots are being regenerated and the user tries to view the Desktop report they will now see something like this:
This placeholder info persists until the run completes
The actual report appears when the run is done