Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the error body is not a buffer; release v0.5.12 #48

Merged
merged 1 commit into from Nov 18, 2019
Merged

Ensure the error body is not a buffer; release v0.5.12 #48

merged 1 commit into from Nov 18, 2019

Conversation

d00rman
Copy link
Contributor

@d00rman d00rman commented Nov 12, 2019

Bug: T238083

Pchelolo
Pchelolo reviewed Nov 12, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@d00rman
Copy link
Contributor Author

d00rman commented Nov 13, 2019

@Pchelolo amended as per your comments (except detail, for which I left the rationale in a comment above).

@d00rman d00rman merged commit bbe51f3 into wikimedia:master Nov 18, 2019
@d00rman d00rman deleted the rel/v0.5.12 branch November 18, 2019 15:01
@d00rman
Copy link
Contributor Author

d00rman commented Nov 18, 2019

Published as v0.5.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pchelolo Pchelolo Pchelolo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d00rman @Pchelolo