Make exception handling more robust for background updates and release v0.7.3 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return P.try(function() { | ||
| return P.each(res.items.reverse(), handler.handleRow.bind(handler)); | ||
| }).catch(function() { | ||
| // noop here for now |
There was a problem hiding this comment.
Could add logging here, at least we would know smth happened.
|
LGTM, except one suggestion about logging. |
|
I have released v0.7.2 in order to be able to re-deploy the last version of RESTBase with only the new version of the storage module. |
d00rman
changed the title
|
v0.7.3 has been released to npm, https://gerrit.wikimedia.org/r/223297 is the deployment candidate only bumping the version |
| }) | ||
| .catch(function(err) { | ||
| if (!options.retries) { | ||
| throw err; | ||
| return P.reject(err); |
There was a problem hiding this comment.
This is equivalent to throw, as it is inside a promise handler.
|
LGTM overall, just two small cases where I think a .catch is not needed / doesn't make a difference. |
|
@gwicke forgot to remove these useless (and desperate) changes. Removed them. |
gwicke
added a commit
that referenced
this pull request
Jul 10, 2015
Make exception handling more robust for background updates and release v0.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T104581