Some more storage group tweaks #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default enforces a bettom-up code style with helpers being grouped before the meat of a class. Per http://jshint.com/docs/options/#latedef, setting this option to "nofunc" restricts this warning to variables only, which still catches typical use-before-define situations (which are fatal in strict mode anyway).
This entire area is quite hacky, but at least it does share the config for now.
Storage group handling depends on the configuration and is stateful, so seems to be better placed in the DB class. Also: - Add keyspaceNameCache: hashing is quite expensive, and did show up at around 1% of total CPU usage in profiling. - Move `InternalRequest` to the end of the file, so that it doesn't break the flow of DB. The previous JSHint config patch makes that possible. - Make `_buildStorageGroups` side-effect free. - Optimize deleted row removal. Deletions are fairly rare, so filtering is not the fastest option in the common (no deletions) case. The filter function accounted for 50% of the time spent in db.js, and around 0.6% of total time.
Coveralls has been quite shaky recently. We don't want to get spurious failures from a 'nice-to-have' service, so don't depend on it.
1 similar comment
|
Merged, so that we can test on the test cluster & base work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.