Added a check for an extra column and tests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -330,6 +330,13 @@ validator.validatePutRequest = function(req, schema) { | |||
| throw new Error('Invalid query. No schema for ' + req.table); | |||
| } | |||
|
|
|||
| var missingColumn = Object.keys(req.attributes).find(function(attrName) { | |||
There was a problem hiding this comment.
Could we separate this into its own method (and then call it from this one), so that we can reuse it in the Cassandra module and reduce code duplication?
There was a problem hiding this comment.
This will be dealt with differently in the Cassandra module, so retracting my question.
d00rman
pushed a commit
that referenced
this pull request
Sep 22, 2015
Added a check for an extra column and tests
|
Damn, v0.0.7 already exists. Will create a new PR for bumping the version |
|
Ah, v0.0.7 already exists as of #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to insert a field that's not in the schema, cassandra silently ignores that and SQLite is throwing a non-descriptive error. However, extra fields clearly indicate a bug in the client - either on table schema, or on a query, so we need to fail-fast and throw an error.
After this is merged, SQLite module would be updated to require the news version of spec and anew version of sqlite will be released.