Update required media item fields #1000
Conversation
As of https://gerrit.wikimedia.org/r/#/c/436360/ (adding support for Mathoid images) media items may not have the usual set of Commons metadata. This updates the media spec to fix the monitoring check.
|
Congrats @mdholloway - you've made PR #1000 :) |
|
\o/ |
|
1 test is still failing for the media endpoint. |
mdholloway
force-pushed
the
required-media-items
branch
from
00d5fe0
to
23e267b
Compare
|
@mdholloway It would also be good for RB's and MCS' specs to have the same |
mdholloway
force-pushed
the
required-media-items
branch
from
23e267b
to
b27005b
Compare
|
@mdholloway test is still failing with |
To actually fix the monitoring check.
mdholloway
force-pushed
the
required-media-items
branch
from
b27005b
to
ef92534
Compare
See https://gerrit.wikimedia.org/r/#/c/437636/. Small change to follow in restbase as well. |
Follow-up from wikimedia#1000 (comment). Reconciles this check with mobileapps to aid in diagnosing alerts. See also https://gerrit.wikimedia.org/r/#/c/437636/ on the mobileapps side.
| - type | ||
| - thumbnail | ||
| - license | ||
| - original |
There was a problem hiding this comment.
There is something wrong here @mdholloway : the spec test requires section_id and type to be present, but the definition additionally requires the original field. These need to match.
As pointed out by mobrovac[1], this will make it easier to diagnose alerts. [1] wikimedia/restbase#1000 (comment) Change-Id: I6d3e951a72cbfababef22195aa0d73d211ddca9b
As of https://gerrit.wikimedia.org/r/#/c/436360/ (adding support for
Mathoid images) media items may not have the usual set of Commons
metadata. This updates the media spec to fix the monitoring check.