-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEMP! Split PDF traffic #1043
TEMP! Split PDF traffic #1043
Conversation
It's a no-op until a config change. We can make the config change in beta cluster only for now. On a later stage we will expose the type and format parameters as well - as soon as we're sure we're switching to the new imlementation. |
The tests pass locally... interesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should also remember to make a grafana dashboard for Proton.
Created T201158 for that. Let's not merge this PR until that is completed. |
@Pchelolo could we also have an undocumented query param that allows one to retrieve the PDF generated by Proton? I figure this would be very helpful for Reading to evaluate the visual output that it generates. |
Done, added |
Obrigado @Pchelolo ! |
Change-Id: I2cd0166620c9933e37c600af5b65ced4fd7009b5
Change-Id: Ieb8ca86a67ece346273a02240889482c5e365be0
Change-Id: Idf03eef3feefa82aa308d4f674870ec4d05f15e0
https://phabricator.wikimedia.org/T186748