Added rvslots=main to the MW API revision request. #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's a call that needs fixing in a test, too: https://github.com/wikimedia/restbase/blob/master/test/features/errors/invalid_request.js#L32-L42 |
jdforrester
approved these changes
Aug 16, 2018
|
Oh thank you, great find @mdholloway |
|
Actually, now that I look closer, why are you requesting contentmodel? It doesn't appear to be used. |
|
Indeed we don't @mdholloway. Maybe we did before... Let's remove it |
Actually, let's not remove it as a part of this commit, but make a separate one. It's not related to this at all. |
|
The reason I bring it up is because I think if you're not requesting the |
|
Hm... ok. let's redo this :) |
It's not needed and usage of it without rvslots is deprecated. Bug: https://phabricator.wikimedia.org/T201974 Change-Id: I2b6a05d6acfcf9953340ab3c8d7f2b739f118211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://phabricator.wikimedia.org/T201974