Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics top endpoints #1070

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Update metrics top endpoints #1070

merged 1 commit into from
Sep 27, 2018

Conversation

jobar
Copy link
Contributor

@jobar jobar commented Sep 26, 2018

This patch is to match AQS patches related to T204707.
Wikistats-2 metrics top endpoint now follow the same
convention as top-pageviews, meaning they do not use
a date range anymore, but rather a single day or month.

This patch is to match AQS patches related to T204707.
Wikistats-2 metrics top endpoint now follow the same
convention as top-pageviews, meaning they do not use
a date range anymore, but rather a single day or month.
@Pchelolo
Copy link
Contributor

Side note: I really want to resolve T204981 cause PRs like this are making me sick.

LGTM. But I will not merge it until tomorrow because of a huge deployment we're making with parisng and we might need to make some quick fixes.

@jobar what's your timeline on this?

@jobar
Copy link
Contributor Author

jobar commented Sep 26, 2018

@Pchelolo : It would be perfect if we could have this deploy by tomorrow EOD (we have other devs dependent on this one), but there it is not crucial. If you feel more comfortable waiting for early next week (no deploys on friday, right?), please do so :).
I also +1 resolving T204981. I'm a bit tired of duplicating all our endpoints.
Thanks !

@Pchelolo
Copy link
Contributor

This does not interfere with other stuff, so I will include it as soon as possible. But it might get undeployed and deployed back a couple of times.

If you could provide some ideas on T204981 that would be awesome. It's getting a bit overwhelming to do all of this without an automated way.

@Pchelolo Pchelolo merged commit 20e1065 into wikimedia:master Sep 27, 2018
@d00rman d00rman added the API label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants