Drop unnecessary console output from testing #108
Conversation
| return restbase({ | ||
| logging: { | ||
| name: 'restbase-tests', | ||
| level: offline ? 'fatal' : 'warn', // hide warnings during offline tests | ||
| level: 'fatal' |
There was a problem hiding this comment.
Should we default to 'warn' level?
|
Chatted with @gwicke , and we realized a better solution is to use a monoidal log, rather than the console, that we can check at the end of execution. |
|
I added a super crappy test logger that collects all log entries, which we can check at the end. It would be good to improve this by adding per-test checks that look at the log and verify that they introduced the expected entries, if any. On the plus side, we're not left to visual inspection of the test output to catch unexpected log entries -- we can explicitly test for them instead. |
|
Oof, this hurts coverage,since it no longer exercies the real logger. |
| function collect(context) { | ||
| return function() { | ||
| var ctx = JSON.stringify(context); | ||
| if (/^warn/.test(arguments[0]) || |
There was a problem hiding this comment.
Minor: You could simplify this to /^(?:warn|error|fatal)/.test()
|
Closing this in favor of an alternative in progress. |
These console outputs were useful at one point, during the development of certain tests, but now are just noising up the test output.
Ideally, the passing/failing of tests should tell us what we need to know about our test results, so nothing from the console should be needed, except for ad-hoc debugging of tests.