Removed sections.offsets table #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed use of sections.offsets table and modified code to use data-parsoid instead
|
This only removes it from fallback tables. There's also latest tables, need to remove as well. Look: https://github.com/wikimedia/restbase/blob/master/sys/parsoid.js#L261 |
Removed section.offsets from latest tables and from all projects
Pchelolo
suggested changes
Nov 2, 2018
projects/wmf_default.yaml
Outdated
| @@ -18,12 +18,12 @@ paths: | |||
| allows us to contact you quickly. Email addresses or URLs | |||
| of contact pages work well. | |||
|
|
|||
| By using this API, you agree to Wikimedia's | |||
| By using this API, you agree to Wikimedia's | |||
There was a problem hiding this comment.
i know it's bad to have trailing spaces, but this change is entirely unrelated to the purpose of this commit/PR. could you please revert this?
We try to avoid stashing unrelated changes into pull requests, it convolutes the history and git blame becomes useless.
projects/wmf_default.yaml
Outdated
| [Terms of Use](https://wikimediafoundation.org/wiki/Terms_of_Use) and | ||
| [Privacy Policy](https://wikimediafoundation.org/wiki/Privacy_policy). | ||
| Unless otherwise specified in the endpoint documentation | ||
| below, content accessed via this API is licensed under the | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) |
projects/wmf_enwiki.yaml
Outdated
| @@ -18,12 +18,12 @@ paths: | |||
| allows us to contact you quickly. Email addresses or URLs | |||
| of contact pages work well. | |||
|
|
|||
| By using this API, you agree to Wikimedia's | |||
| By using this API, you agree to Wikimedia's | |||
projects/wmf_wikidata.yaml
Outdated
| [Terms of Use](https://wikimediafoundation.org/wiki/Terms_of_Use) and | ||
| [Privacy Policy](https://wikimediafoundation.org/wiki/Privacy_policy). | ||
| Unless otherwise specified in the endpoint documentation | ||
| below, content accessed via this API is licensed under the | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) |
projects/wmf_wikidata.yaml
Outdated
| @@ -18,12 +18,12 @@ paths: | |||
| allows us to contact you quickly. Email addresses or URLs | |||
| of contact pages work well. | |||
|
|
|||
| By using this API, you agree to Wikimedia's | |||
| By using this API, you agree to Wikimedia's | |||
projects/wmf_wikipedia.yaml
Outdated
| @@ -18,12 +18,12 @@ paths: | |||
| allows us to contact you quickly. Email addresses or URLs | |||
| of contact pages work well. | |||
|
|
|||
| By using this API, you agree to Wikimedia's | |||
| By using this API, you agree to Wikimedia's | |||
projects/wmf_wikipedia.yaml
Outdated
| [Terms of Use](https://wikimediafoundation.org/wiki/Terms_of_Use) and | ||
| [Privacy Policy](https://wikimediafoundation.org/wiki/Privacy_policy). | ||
| Unless otherwise specified in the endpoint documentation | ||
| below, content accessed via this API is licensed under the | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) |
projects/wmf_wiktionary.yaml
Outdated
| @@ -19,15 +19,15 @@ paths: | |||
| allows us to contact you quickly. Email addresses or URLs | |||
| of contact pages work well. | |||
|
|
|||
| By using this API, you agree to Wikimedia's | |||
| By using this API, you agree to Wikimedia's | |||
projects/wmf_wiktionary.yaml
Outdated
| [Terms of Use](https://wikimediafoundation.org/wiki/Terms_of_Use) and | ||
| [Privacy Policy](https://wikimediafoundation.org/wiki/Privacy_policy). | ||
| Unless otherwise specified in the endpoint documentation | ||
| below, content accessed via this API is licensed under the | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) | ||
| [CC-BY-SA 3.0](https://creativecommons.org/licenses/by-sa/3.0/) |
projects/wmf_wiktionary.yaml
Outdated
| and [GFDL](https://www.gnu.org/copyleft/fdl.html) licenses, | ||
| and you irrevocably agree to release modifications or | ||
| additions made through this API under these licenses. | ||
| additions made through this API under these licenses. |
Reverted trailing spaces in projects/ files to original spacing
Pchelolo
approved these changes
Nov 2, 2018
|
Let's wait for travis, but LGTM. in the meantime, could you please create a subtask for the ticket, saying to delete section-offsets keyspaces in labs, dev and prod and assign it to @eevans ? i will get back on the ticket with a list of keyspace names. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed use of sections.offsets table and modified
getSectionsto use data-parsoid instead.Bug T206048