Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed: Ensure result[0].body.tfa exists #1088

Merged
merged 1 commit into from Dec 13, 2018

Conversation

d00rman
Copy link
Contributor

@d00rman d00rman commented Dec 13, 2018

There have been ~1200 failed requests in the last 24h where result[0].body.tfa was undefined, which made RB fail when trying to set the thumbnail. Since the Android app expects these fields to be present, ensure they are defined.

Bug: T211871

There have been ~1200 failed requests in the last 24h where
`result[0].body.tfa` was undefined, which made RB fail when trying to
set the thumbnail. Since the Android app expects these fields to be
present, ensure they are defined.
@d00rman d00rman added the bug label Dec 13, 2018
@d00rman
Copy link
Contributor Author

d00rman commented Dec 13, 2018

cc @Pchelolo @mdholloway @berndsi

@d00rman
Copy link
Contributor Author

d00rman commented Dec 13, 2018

Self-merging for now and deploying to alleviate the problem.

@d00rman d00rman merged commit 0e11251 into wikimedia:master Dec 13, 2018
@d00rman d00rman deleted the feed/body-tfa-exists branch December 13, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant