Remove optional parameters in sys/ #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d00rman
requested changes
Apr 8, 2019
clarakosi
force-pushed
the
sys
branch
5 times, most recently
from
4081deb
to
d90f218
Compare
Pchelolo
reviewed
Apr 9, 2019
Pchelolo
reviewed
Apr 9, 2019
|
One comment inlined, otherwise LGTM |
Removed optional parameters from sys/, test/, and remaining mentions in v1/. Bug: T218218
d00rman
approved these changes
Apr 9, 2019
|
Nice PR number! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed optional parameters from sys/ and test/test_module.yaml.
Bug: T218218