Purge remainder of calls to new Date.

[cscott]

Use Date.now and Date.parse instead.

[earldouglas]

+apiRev.timestamp

What does the leading plus do?

[cscott]

Coerces to numeric, just to be safe. Below in the tidToDate method it should catch the oddball case where (say) date.getTime() is a method, but returns some non-numeric value, like {}, since isNaN(+{}) === true.

Here it will ensure that apiRev.timestamp is treated as a number, even if it happens to be a string like "123". (Note that new Date("2") does surprising things, which this code previously didn't protect against.)

[gwicke]

Travis does not seem to be happy, and it doesn't look like a transient issue to me.

[cscott]

It's possible I screwed something up, I'll figure out how to run the test suite later tonight.

[gwicke]

@cscott, to run the tests, you need to install & run cassandra locally. With that in place, it's just npm test.

[earldouglas]

Note: there are multiple options for installing Cassandra. I found the quickest method was to download the tarball, extract it, and run bin/cassandra.

[gwicke]

I'm preferring apt-get install cassandra ;)

On Wed, Jan 7, 2015 at 4:42 PM, James Earl Douglas <notifications@github.com

wrote:

Note: there are multiple options for installing Cassandra. I found the
quickest method was to download the tarball
https://cassandra.apache.org/download/, extract it, and run
bin/cassandra.

—
Reply to this email directly or view it on GitHub
#112 (comment).

[earldouglas]

$ apt-cache search cassandra
pycassa-doc - Documentation for the Pycassa library
python-pycassa - Client library for Apache Cassandra

:sadface:

[gwicke]

http://wiki.apache.org/cassandra/DebianPackaging

On Wed, Jan 7, 2015 at 4:45 PM, James Earl Douglas <notifications@github.com

wrote:

$ apt-cache search cassandra
pycassa-doc - Documentation for the Pycassa library
python-pycassa - Client library for Apache Cassandra

:sadface:

—
Reply to this email directly or view it on GitHub
#112 (comment).

[coveralls]

Coverage increased (+0.12%) when pulling e6a2eb9 on cscott:date-now-2 into 5984df8 on wikimedia:master.

[coveralls]

Coverage increased (+0.12%) when pulling e6a2eb9 on cscott:date-now-2 into 5984df8 on wikimedia:master.

[cscott]

Fixed. (apiRev.timestamp is a string; I thought it was numeric.)