Update specs to OpenAPI 3.0.1 #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pchelolo
reviewed
Apr 17, 2019
Pchelolo
reviewed
Apr 29, 2019
Pchelolo
changed the title
|
clarakosi
force-pushed
the
v3.0.1
branch
2 times, most recently
from
5194446
to
174760a
Compare
|
Rebased but I still need to update service-checker to also look for the base URL at |
|
We are not going to deploy this very soon, so no rush |
|
@clarakosi I think we are finally getting ready to deploy this :) Could you (a) rebase on top of current master (a lot of things have changed!); and (b) bump hyperswitch' version to 0.12.2, please? |
@clarakosi euh, this moved to v0.12.3 :P |
clarakosi
force-pushed
the
v3.0.1
branch
2 times, most recently
from
2abad4e
to
3cf9836
Compare
d00rman
reviewed
May 28, 2019
d00rman
reviewed
May 28, 2019
d00rman
reviewed
May 28, 2019
d00rman
reviewed
May 28, 2019
clarakosi
force-pushed
the
v3.0.1
branch
2 times, most recently
from
3e8943c
to
8ab854c
Compare
Pchelolo
reviewed
May 28, 2019
|
One small comment, otherwise it's great! |
Bug: T218218
|
Great! |
Pchelolo
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on Hyperswitch PR
I should’ve caught this earlier but the online swagger validator we were using does not support v3.
Instead of waiting for swagger-cli to update its dependency (swagger-parser using openapi-schema-validation v0.4.2 instead of v3.0.3) I’ve elected to use openapi-schema-validation v3.0.3 directly. I am open to other suggestions.
Summary of major changes in v3:
swagger: 2.0has been replaced withopenapi: 3.0.1definitionswas renamed toschemasandsecurityDefinitionstosecuritySchemesand they all were moved inside componentsserversreplaces thebasePathkeywords used in OpenAPI 2.01. ISSUE/ Additional work: Service checker expects a basePath. It needs to be updated to also look for servers[0].url2. https://github.com/wikimedia/operations-software-service-checker/blob/master/servicechecker/swagger.py#L109
producesreplaced withcontentinresponse. Must include media type & schema.consumeshas been replaced withrequestBodytypeinparametersto show up underschemaUnclear/ Need help:I’m not fully sure how redirect works in the codebase. For example, with
html/{title}&&html/{title}/{revision}we have it accepting a boolean (in spec) but some of the tests are providing the valuenoto the query. I’ve gone through some of the code in sys/ but I am having a hard time tracking it down.