Mathoid: Move resource declarations into the sys/ module #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource declarations for the images' buckets resided in v1/mathoid.yaml, all of them creating the images' buckets in the global domain. Alas, this causes RESTBase to issue check-and-create-bucket requests for them for each domain it loads. Therefore, to optimise the start-up process, move them to sys/mathoid.js, which is loaded only for the global domain.
|
Makes sence. |
|
Let's wait for travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource declarations for the images' buckets resided in
v1/mathoid.yaml, all of them creating the images' buckets in the global
domain. Alas, this causes RESTBase to issue check-and-create-bucket
requests for them for each domain it loads. Therefore, to optimise the
start-up process, move them to sys/mathoid.js, which is loaded only for
the global domain.