Add suggested edits endpoints, take 2 #1159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds four new recommendation endpoints:
- /data/recommendation/caption/addition/{target}
- /data/recommendation/caption/translation/from/{source}/to/{target}
- /data/recommendation/description/addition/{target}
- /data/recommendation/description/translation/from/{source}/to/{target}
The caption suggestion endpoints are supported only for Commons domains,
and the description suggestion endpoints are supported only for Wikidata
domains.
Support for commons.wikimedia.org as a default project is added to
config.example.wikimedia.yaml for development and testing.
Support for recommendations endpoints is added to the wikidata.org
project in the example config.
Phab: https://phabricator.wikimedia.org/T224754
1- Rebase. 2- Split recommend configurations and add into projects wikidata.wmf and commons.wmf. 3- Create commons.wmf per copy of default.wmf and add recommend-caption entries.
1- Remove commons from projects and add recommend-caption direct in the config file 2- Add wikidata and commons to the monitoring test script as allowed domains
These endpoints will be monitored at the service level and do not need additional monitoring here.
mdholloway
changed the title
thesocialdev
reviewed
Jul 2, 2019
| - path: projects/v1/default.wmf.yaml | ||
| options: *default_options | ||
| - path: v1/recommend-caption.yaml | ||
| options: '{{options.recommendation}}' |
There was a problem hiding this comment.
This doesn't work because options is 'undefined' when declared like this. The right thing to do is done in the other PR https://github.com/wikimedia/restbase/pull/1153/files#diff-b91bbd009bed6f8dfe87647993d47521R119
There was a problem hiding this comment.
All right, I'll try picking that one back up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds four new recommendation endpoints:
The caption suggestion endpoints are supported only for Commons domains,
and the description suggestion endpoints are supported only for Wikidata
domains. (This is enforced in the service configuration, and is not reflected here.)
Support for commons.wikimedia.org as a default project is added to
config.example.wikimedia.yaml for development and testing.
Support for recommendations endpoints is added to the wikidata.org
project in the example config.
Phab: https://phabricator.wikimedia.org/T224754
(Note: This is a continuation of #1153 after rewriting some history in a way Git doesn't necessarily appreciate.)