Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify config.example.yaml to avoif using projects #1180

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

Pchelolo
Copy link
Contributor

I think having an example config not using the projects is simpler for small installs and developers.

@Pchelolo Pchelolo requested a review from d00rman August 30, 2019 18:08
Copy link
Contributor

@d00rman d00rman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but I'd prefer if the routes were organised under the same domain tree and not split along /domain/api (i.e. the whole path string). So perhaps something like:

paths:
  /{domain:localhost}:
    x-modules:
      - spec:
          paths:
            /{api:v1}:
            /{api:sys}:

What do you think?

@Pchelolo
Copy link
Contributor Author

Pchelolo commented Sep 3, 2019

I'm quite indifferent :) Your proposal makes it a couple lines longer, but I guess it shows more how combining different sub-trees works... mmmm... yeah. I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants