MCS: Stop using storage for wiktionary definitions #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdholloway
approved these changes
Sep 3, 2019
Pchelolo
reviewed
Sep 3, 2019
| @@ -150,35 +100,7 @@ paths: | |||
| content-type: '{{extract.headers.content-type}}' | |||
| vary: '{{extract.headers.vary}}' | |||
| body: '{{extract.body}}' | |||
| - emit_change_event: | |||
There was a problem hiding this comment.
The response_cache_control here will still be pretty long. We need to either return some kind of purging or make much smaller cache max-age
There was a problem hiding this comment.
In the CP config patch we keep the purging side of things, so this will not be an issue.
There was a problem hiding this comment.
No. If you don't emit the resource-change for this route, no purge will be emitted.
There was a problem hiding this comment.
Indeed, I'll add a purge event to the CP config, that ought to fix it.
There was a problem hiding this comment.
@Pchelolo updated the CP config patch to reflect what we discussed here
d00rman
force-pushed
the
mcs/no-definition-storage
branch
from
c9c19b9
to
f4f84e2
Compare
|
+1, waiting for travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T231361