Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accept-language header for /page/related #1229

Merged
merged 6 commits into from
Feb 5, 2020

Commits on Jan 9, 2020

  1. Fix accept-language header for /page/related

    1) Forward headers to summary endpoint to fetch proper displaytitle for
    language variant
    2) Add test using zh beta
    3) TODO: Identify why language_variants_filter.js#12 is deleting
    accept-language header and not forwarding it.
    
    Bug: T231609
    thesocialdev committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    fb7fcb0 View commit details
    Browse the repository at this point in the history
  2. 1) fix res header override bug

    2) Pass vary and content-language to response
    thesocialdev committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    2d1179c View commit details
    Browse the repository at this point in the history
  3. 1) Fix fetchSummary addVaryHeader call

    2) Remove unneeded check of shouldConvert
    3) Test if accept-language is present in vary header
    thesocialdev committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    3fc2383 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f69478 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. 1) perform deep clone when cloning request

    2) move related tests to language_variants
    3) return req instead of undefined
    thesocialdev committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    33b9937 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. 1) fetchSummary to return content-language

    2) Fix some linting issues
    3) apply fetchSummary calls to check for summary key when hydrating
    responses
    4) Deep clone only needed params at language_variant_filter
    thesocialdev committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    ce8d295 View commit details
    Browse the repository at this point in the history