Add mobile-html-offline-resources endpoint #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good. Lemme see what is travis upset about, it's unrelated. |
|
Hm.. it seems like PCS /v1/transform/html/to/mobile-html/{title} has changed somehow and now it's not really transforming parsoid html but returns html for the provided {title} |
This test was broken by a change to mobileapps to more aggressively strip empty sections in mobile-html. Some section body text is added to the input to fix it.
mdholloway
force-pushed
the
offline-resources
branch
from
730cf27
to
9be31f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://phabricator.wikimedia.org/T244175