Bump mediawiki-title to v0.7.4 #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix a redirect loop where the core Title implementation allows soft-hyphens (U+00AD) but mediawiki-title was stripping them. This mismatch happened because a change only got reverted in one of the implementations. See wikimedia/mediawiki-title#51 Bug: T284734
|
No sure if this PR breaks things... or if the whole CI is broken... |
I get the same 6 failures on the main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix a redirect loop where the core Title implementation allows
soft-hyphens (U+00AD) but mediawiki-title was stripping them. This
mismatch happened because a change only got reverted in one of the
implementations.
See wikimedia/mediawiki-title#51
Bug: T284734
/cc @Pchelolo @subbuss