Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve redirects for page/related endpoint #1295

Conversation

VadimKovalenkoSNF
Copy link
Contributor

Implement private _relatedPageRedirect() method for resolving article redirects

BUG: T289575

Copy link
Member

@clarakosi clarakosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a couple of small comments below

v1/related.js Outdated Show resolved Hide resolved
v1/related.js Outdated Show resolved Hide resolved
@thesocialdev
Copy link
Contributor

@clarakosi I think this is ready for review

v1/related.js Outdated Show resolved Hide resolved
@Pchelolo
Copy link
Contributor

Pchelolo commented Feb 7, 2022

please rebase it on current master, it has CI fixed.

@VadimKovalenkoSNF VadimKovalenkoSNF force-pushed the T289575-resolve-redirects-for-page-related-endpoint branch from 9e3acc2 to 49bd3ea Compare February 11, 2022 17:19
@VadimKovalenkoSNF
Copy link
Contributor Author

please rebase it on current master, it has CI fixed.

Done, pls check.

@clarakosi clarakosi merged commit faf6e4c into wikimedia:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants