Pull in cassandra driver v2 for testing #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets pull in the git branch for testing of the v2 driver in this branch. Can then release that & switch to the release after testing.
gwicke
force-pushed
the
cassandra_driver_v2
branch
from
f3edf50
to
0fd2039
Compare
2 similar comments
|
Hm, I see a new |
|
@d00rman, I had the same thought, but then realized that it actually matters more how we push this into the deploy repo. I already used this code for wiki creation testing yesterday, where the v2 driver proved reliable. |
This is a left-over from past days.
Node 0.10 has a nextTick recursion limit of 500, which we hit when processing 800 domains without any async operations in between (perfect caching & sharing of CFs). This patch adds a `.delay(0)` (which works out to a `setTimeout(0)` to break the cycles.
This allows a more natural top-down style, where helpers are defined after the main entry points.
.group actually looks like a TLD: http://www.instra.com/en/domain-names/newgtld/group-domain-registration/group .local on the other hand is dedicated to local use, so won't clash with glocal domains. Also fix up the cleandb script to clear the test domains.
Page title and revision listings don't currently work with domain multiplexing. They are also low priority features, so it's okay to disable these for now.
|
Changes Unknown when pulling f9c0b3c on gwicke:cassandra_driver_v2 into * on wikimedia:master*. |
The unconditional catch handler in parsoid.js triggered content generation on *any* errors, not just 404s. This led to a large number of revisions to be stored on some pages I was using for benchmarking. It also covered up a bug in the handling of requests for 'latest' revisions. The frontend code (and a test) was creating internal requests with 'latest' as the revision, but the revision parsing code in key_rev_value did not consider that a valid revision. Combined with the earlier bug this meant that each request for an existing version was causing a new revision to be parsed & saved. This patch solves both problems by - only generating content on 404, and re-raising any other errors, and - dropping the `/latest` pseudo-revision in favor of a straight request for the title.
|
Changes Unknown when pulling 882f01a on gwicke:cassandra_driver_v2 into * on wikimedia:master*. |
The unconditional catch handler in parsoid.js triggered content generation on *any* errors, not just 404s. This led to a large number of revisions to be stored on some pages I was using for benchmarking. It also covered up a bug in the handling of requests for 'latest' revisions. The frontend code (and a test) was creating internal requests with 'latest' as the revision, but the revision parsing code in key_rev_value did not consider that a valid revision. Combined with the earlier bug this meant that each request for an existing version was causing a new revision to be parsed & saved. This patch solves both problems by - only generating content on 404, and re-raising any other errors, and - dropping the `/latest` pseudo-revision in favor of a straight request for the title.
gwicke
force-pushed
the
cassandra_driver_v2
branch
from
882f01a
to
b6ed3d4
Compare
The previous commit to remove the 'latest' request was not complete. We
evidently don't have good tests for the timple /page/html/{title} case.
TODO: Properly test that area.
Sub-requests that don't directly throw errors (primarily cassandra at this point) don't get very good error reporting right now, as much of the information is lost while being wrapped into an HTTPError. This patch improves this slightly by preserving more information.
This reverts commit 0dc4cf8. Several unrelated WIP changes had snuck into that commit, so undo them here. Conflicts: lib/restbase.js
gwicke
added a commit
that referenced
this pull request
Mar 4, 2015
Pull in cassandra driver v2 for testing
|
Merging without waiting for travis after triple-checking the tests locally. Travis seems to be down right now. |
|
The travis run was actually fine, only the reporting failed apparently: https://travis-ci.org/wikimedia/restbase/builds/53063025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge until we have tested this a bit on the test cluster.