Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve invalid request handling #236

Merged
merged 1 commit into from
Apr 24, 2015
Merged

Improve invalid request handling #236

merged 1 commit into from
Apr 24, 2015

Conversation

gwicke
Copy link
Member

@gwicke gwicke commented Apr 23, 2015

  • Fix reading of PUT / JSON POST requests
  • Catch & report errors for invalid POSTs
  • Make sure the internal request is always defined, so that we can use it in
    error reports
  • Add tests

@gwicke
Improve invalid request handling
d6648a0 
- Fix reading of PUT / JSON POST requests
- Catch & report errors for invalid POSTs
- Make sure the internal request is always defined, so that we can use it in
  error reports
- Add tests
@gwicke
Copy link
Member Author

gwicke commented Apr 23, 2015

/cc @eevans @d00rman

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 86.94% when pulling d6648a0 on gwicke:master into 0b9a043 on wikimedia:master.

d00rman pushed a commit that referenced this pull request Apr 24, 2015
Merge pull request #236 from gwicke/master
670f63a 
Improve invalid request handling
@d00rman d00rman merged commit 670f63a into wikimedia:master Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eevans eevans

Labels
None yet
Milestone
No milestone
4 participants
@gwicke @coveralls @eevans @d00rman