Updated CORS headers #690
Merged
Updated CORS headers #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should also be made to the node service template, so it can be picked up by other services, like MCS. |
|
@berndsi Yep, that's the plan after we discuss this PR |
gwicke
reviewed
Oct 19, 2016
| @@ -59,7 +59,8 @@ module.exports = function addCSPHeaders(hyper, req, next, options) { | |||
| // Set up basic CORS headers | |||
| rh['access-control-allow-origin'] = '*'; | |||
| rh['access-control-allow-methods'] = 'GET'; | |||
| rh['access-control-allow-headers'] = 'accept, content-type'; | |||
| rh['access-control-allow-headers'] = | |||
| 'accept, accept-encoding, origin, accept-language, content-type'; | |||
There was a problem hiding this comment.
It's actually impossible to override origin in clients, as it is part of verifying the domain comes from as part of the CORS system. Adding it here would just be confusing.
There was a problem hiding this comment.
@gwicke Safari 9 sends it with an OPTIONS request. As I understand, normally you need to send back all the headers from OPTIONS preflight request to allow it and I couldn't find anything about Origin header being somehow specific
Pchelolo
added a commit
to Pchelolo/restbase
that referenced
this pull request
Oct 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://phabricator.wikimedia.org/T148368
Also updated one test page location, it's been deleted on wikipedia, moved it to labs.
cc @wikimedia/services