Respect the table prefix for timelines #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6653c86c28ea26b012a8c065cd0fab171bbc96fe
|
If Travis is good, so am I; LGTM |
|
We shouldn't merge/deploy it yet until we finish testing in dev cluster as this will rename the timeline tables and potentially break everything. |
|
Travis is now happy as well. |
Well, not really. If the data is absent from the timeline table (which would be the case after deploying this, as they would be empty), older revisions/renders won't get deleted until a new one comes along. |
|
Merging as we need this before putting it out into prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't share the timelines between use-cases, so need to respect the table prefix there.
cc @wikimedia/services