Do not cache feeds for the current day in cassandra #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pchelolo
changed the title
Change-Id: I55016bb26ae60efd6692cbcbe693adb012692ac2
Pchelolo
force-pushed
the
feed_cache_control
branch
from
af3bec3
to
2a78511
Compare
|
Rebased, travis is passing now. |
d00rman
reviewed
Sep 22, 2017
projects/wmf_default.yaml
Outdated
| @@ -83,11 +83,11 @@ paths: | |||
| /feed: | |||
| x-modules: | |||
| - path: v1/feed.js | |||
| options: '{{merge({"feed_cache_control": "s-maxage=300, max-age=60", "ttl": 7200}, options.mobileapps)}}' | |||
| options: '{{merge({"feed_cache_control": "s-maxage=300, max-age=60", "ttl": 300}, options.mobileapps)}}' | |||
There was a problem hiding this comment.
The ttl is not used any more, so it can be safely removed (here and elsewhere).
Change-Id: I5d5c66bdb1eed0f8e5b57c5d382910fd8d637660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were caching the result of the feed request for the current day in Cassandra, but it doesn't really make any sense - regenerating it is quite fast.
Bug: https://phabricator.wikimedia.org/T176233
cc @wikimedia/services